Look up code references within libraries by map rather than traversing a list #1829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…brary and optimize lookup for _findPartiallyQualifiedMatches
pq
approved these changes
Nov 13, 2018
| _getResultsForClass( | ||
| tryClass, codeRefChomped, results, codeRef, packageGraph); | ||
| } | ||
| results.remove(null); |
There was a problem hiding this comment.
Nothing all that useful most of the time. Some of the blocks are capable of adding nulls to the results set, but instead of trying to determine exactly which ones could possibly add a null sometimes we just stamp it out every time.
The refactor left these remove(null) calls in some of the functions. Reorganized this dance to be a little more consistent and added a TODO to get rid of it.
lib/src/markdown_processor.dart
Outdated
| } | ||
| } | ||
| } | ||
| results.remove(null); |
There was a problem hiding this comment.
... And why again here and in the super chain loop above?
There was a problem hiding this comment.
Necessary inside the loop because we're again using "set is empty" as a proxy for no results, and sometimes null gets added instead of a result.
|
Thanks for clarifying! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fairly low hanging fruit to improve generator performance, but more risky than #1828. Especially good on heavily code-referenced codebases like Flutter's, around 20% runtime reduction in the generator stage.
Checked with compare-flutter-warnings to make sure it didn't impact generation for Flutter.
Also extracts a few functions to make looking around in the profiler easier.