Skip to content

Classes and helper methods to avoid holding AstNodes #1857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 30, 2018
Merged

Classes and helper methods to avoid holding AstNodes #1857

merged 7 commits into from
Nov 30, 2018

Conversation

jcollins-g
Copy link
Contributor

@jcollins-g jcollins-g commented Nov 29, 2018 •
edited
Loading

Beginning of a refactor to avoid holding on to AstNodes. Here, just transform them to something else and don't cache the original.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Nov 29, 2018
@jcollins-g jcollins-g merged commit ac1cab5 into master Nov 30, 2018
@jcollins-g jcollins-g deleted the remove-crossdart+astconverter branch November 30, 2018 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwilkerson bwilkerson bwilkerson approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcollins-g @bwilkerson @googlebot