Skip to content

Cleanup and move test-only code into the test utils library #1878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 21, 2018
Merged

Cleanup and move test-only code into the test utils library #1878

merged 1 commit into from
Dec 21, 2018

Conversation

jcollins-g
Copy link
Contributor

@jcollins-g jcollins-g commented Dec 20, 2018 •
edited
Loading

Coverage data has highlighted a few refactoring leftovers and some other litter in dartdoc. Remove these. Also, move some test-only code into the test support library.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Dec 20, 2018
@coveralls
Copy link

Coverage Status

Coverage increased (+1.9%) to 91.581% when pulling 1aba175 on cleanup-more-unused into e864efe on master.

@jcollins-g jcollins-g requested a review from pq December 21, 2018 18:50
pq
pq approved these changes Dec 21, 2018
View reviewed changes
Copy link
Member

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcollins-g jcollins-g mentioned this pull request Dec 21, 2018
Merged
@jcollins-g jcollins-g merged commit 04ed8ec into master Dec 21, 2018
@jcollins-g jcollins-g deleted the cleanup-more-unused branch December 21, 2018 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pq pq pq approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jcollins-g @coveralls @pq @googlebot