Change command line flag allow-tools default to false

[keertip]

No description provided.

[devoncarew]

Do we need to update the flutter doc script (in flutter/flutter/dev/tools/dartdoc.dart)?

[devoncarew]

Change the default for the '--allow-tools' command-line flag to false.?

[keertip]

Yes, will update the flutter script before publishing a new version. Flutter does pull in only published versions, right?

[keertip]

#1940

[coveralls]

Coverage decreased (-0.2%) to 93.977% when pulling 897dd7e on tools into 3980fca on master.

[devoncarew]

Yes, will update the flutter script before publishing a new version. Flutter does pull in only published versions, right?

Yes, and I believe they use only explicit versions (the version number is referenced in the script).

[sigurdm]

Does this also disallow enabling --allow-tools from the analysis_options.yaml file as discussed in #1940?

[devoncarew]

It doesn't, but it should like that is something we'd like to do. I'll open an issue to track; PRs welcome for it as well.

[keertip]

The only way to set --allow-tools is through command line. It cannot be set thru the dartdoc_options file.

[sigurdm]

Ah - that was unclear to me. Thanks!