Skip to content

Warn "not yet implemented" for comment reference resolution for extension methods #2040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 14, 2019
Merged

Warn "not yet implemented" for comment reference resolution for extension methods #2040

merged 4 commits into from
Oct 14, 2019

Conversation

jcollins-g
Copy link
Contributor

This should stop the crashes mentioned in #2033. Not a long term solution but will solve the immediate showstopper.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Oct 11, 2019
@coveralls
Copy link

coveralls commented Oct 11, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.004%) to 93.87% when pulling 233df4c on extension-crash into 3375875 on master.

@jcollins-g jcollins-g requested a review from keertip October 11, 2019 20:32
@jcollins-g jcollins-g merged commit fabd65a into master Oct 14, 2019
@jcollins-g jcollins-g deleted the extension-crash branch October 14, 2019 16:19
@jcollins-g jcollins-g mentioned this pull request Oct 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keertip keertip keertip approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jcollins-g @coveralls @keertip @googlebot