Improve couldApplyTo and add tests #2062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwilkerson
approved these changes
Nov 7, 2019
lib/src/model.dart
Outdated
| /// Return true if this extension could apply to [t]. | ||
| bool _couldApplyTo(DefinedElementType t) { | ||
| if (t.element.name == 'Implementor2' && name == 'ExtensionCheckLeft') { | ||
| print('hi'); |
There was a problem hiding this comment.
Dubugging code that should be removed?
There was a problem hiding this comment.
Eventually I will figure out how to make conditional breakpoints more persistent than they seem to be in intellij, but not so persistent that I forget to remove them when uploading PRs. *sigh* Fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make couldApplyTo work for cases involving mixins and interfaces, dropping the original extension-tree implementation at least for now.