Move extendedDocLink creation to ModelElementRenderer #2085
Conversation
Also separate it from oneLineDoc and update the templates accordingly.
| } | ||
| return _oneLineDoc; | ||
| } | ||
| String get oneLineDoc => _documentation.asOneLiner; |
There was a problem hiding this comment.
glad the no-super workaround is gone
test/model_test.dart
Outdated
| 'Returns a length. <a href="fake/WithGetterAndSetter/lengthX.html">[...]</a>')); | ||
| expect(lengthX.oneLineDoc, equals('Returns a length.')); | ||
| expect(lengthX.extendedDocLink, | ||
| equals(ModelElementRendererHtml().renderExtendedDocLink(lengthX))); |
There was a problem hiding this comment.
I think we should have at least one literal matching string here for the Html renderer test, especially since it is very targeted -- otherwise we're simply validating that extendedDocLink returns whatever the renderer does.
|
@jdkoren Also, whenever I touch the templates I like to upload sample screenshots. It helps make sure there's not some subtle rendering problem I introduced, as the unit tests don't always cover how the browser shows something. Could you upload a sample screenshot or two of pages with the changed templates? |
|
Screenshots before and after of a library: Screenshots before and after of a class: I had to add a minor fix to prevent enum ordinal members from showing an extended doc link. |
Also separate it from oneLineDoc and update the templates accordingly.