remove a use of resource loading #2337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the CL we'd need to land in the SDK repo: https://dart-review.googlesource.com/c/sdk/+/161880. |
srawlins
approved these changes
Sep 8, 2020
|
@srawlins - ping me when we next want to roll dartdoc into the sdk repo - we'll need to land my CL at the same time (or put the changes into the roll CL). |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this is only used when generating the docs for the Dart sdk. I'll prep a CL for the drt-lang/sdk repo; it would need to land in the same commit (or soon after) the one that rolls the next version of dartdoc into the sdk.