Skip to content

Give the correct exception even if someone has run pub get already #2440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2020
Merged

Give the correct exception even if someone has run pub get already #2440

merged 1 commit into from
Dec 1, 2020

Conversation

jcollins-g
Copy link
Contributor

Fixes #2407.

Previous code attempting to explain to the user what was wrong here gets missed if the user has run pub get before on their package (which isn't uncommon).

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Nov 30, 2020
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.001%) to 91.377% when pulling bfb4199 on fix-flutter-root-error into d79877d on master.

@jcollins-g jcollins-g requested a review from srawlins November 30, 2020 18:10
@jcollins-g jcollins-g merged commit e35a8d7 into master Dec 1, 2020
@jcollins-g jcollins-g deleted the fix-flutter-root-error branch August 11, 2021 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srawlins srawlins srawlins approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dartdoc command not working (dartdoc failed: Invalid argument(s) (path): Must not be null)
3 participants
@jcollins-g @coveralls @srawlins