Mustachio: Add support for Iterable types in Property, some fixes #2447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcollins-g
approved these changes
Dec 3, 2020
| rendererClassesArePublic: rendererClassesArePublic) | ||
| ._buildTemplateRenderers(specs); | ||
| return DartFormatter().format(raw.toString()); | ||
| } | ||
|
|
||
| /// This class builds runtime Mustache renderers from a set of [RendererSpec]s. | ||
| class RuntimeRenderersBuilder { | ||
| static const _contextTypeVariable = 'CT_'; |
|
|
||
| if (property.isPrivate || property.isStatic || property.isSetter) return; | ||
| _buffer.writeln("'${property.name}': Property("); | ||
| _buffer | ||
| .writeln('getValue: (Object c) => (c as $typeName).${property.name},'); | ||
| .writeln('getValue: ($_contextTypeVariable c) => c.${property.name},'); |
There was a problem hiding this comment.
Nice. It seemed like something like this should have been possible!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isEmptyIterableandrenderIterablewhich are used for sections and inverted sections.CT_(for context type). The propertyMap on a generic type will also have the other generics, for examplepropertyMap<E, CT_>for Renderer_List, andpropertyMap<K, V, CT_>for Renderer_Map. This allows us to spread in inherited properties, like Object'shashMap. The propertyMap for Foo_Renderer cannot claim that the Property representinghashCodehas functions that takeFooinstances; they only take Object. By introducingCT_, we can say that Foo_Renderer's propertyMap spreads in Object_Renderer's propertyMap aspropertyMap<Foo>().