Switch from Source Code Pro to Roboto Mono #2459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe this test is failing due to _fe_analyzer_shared migrating to null safety. Should work once rerun though due to fixes merged recently. |
jcollins-g
suggested changes
Dec 16, 2020
There was a problem hiding this comment.
You're right this looks better. Could you instead give Roboto Mono a try, as used in code examples on the dart.dev site, such as at https://dart.dev/samples? In general when we make changes we try to align to the larger Dart web style where possible.
Also it looks like Travis won't stop trying to run sdk-analyzer against stable unless you resync your PRs, so if you can do that it'll clear the error.
parlough
force-pushed
the
feature/update-code-font
branch
from
3430ab7 to
785c184
Compare
parlough
changed the title
|
@jcollins-g This looks like an improvement as well, good to go on my end :) |
jcollins-g
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous monospace font is a little blurry and many characters feel slightly squished. To standardize with other Dart web tools and improve clarity I suggest switching to Roboto Mono which is licensed under Apache License, Version 2.0.
This also removes Source Sans Pro which was not used at all as far as I could tell.
The rendering result on Chrome Dev (Linux):
Previously(Source Code Pro):
Suggested(Roboto Mono):
SO much better <3