Skip to content

Very minor comment and space util cleanup #2542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 25, 2021
Merged

Very minor comment and space util cleanup #2542

merged 2 commits into from
Feb 25, 2021

Conversation

parlough
Copy link
Member

  • Adds some extra early failure checks
  • Don't use string interpolation when not necessary
  • Switch to using built in StringBuffer.writeln instead of manually appending \n

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Feb 24, 2021
@parlough parlough force-pushed the misc/minor-util-cleanup branch from 9fc56db to a9f376d Compare February 24, 2021 16:32
@coveralls
Copy link

coveralls commented Feb 24, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.08%) to 91.703% when pulling f34a587 on parlough:misc/minor-util-cleanup into d22e3df on dart-lang:master.

@parlough
Copy link
Member Author

The macOS test has been intermittently failing due to timeouts, if you resubmit the checks it may be fine.

jcollins-g
jcollins-g suggested changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@jcollins-g jcollins-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny cosmetic bit

@parlough parlough requested a review from jcollins-g February 25, 2021 17:40
@jcollins-g jcollins-g merged commit 39f1384 into dart-lang:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcollins-g jcollins-g jcollins-g approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parlough @coveralls @jcollins-g