Add option for setting arguments for tool compilation. #2576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gspencergoog
changed the title
gspencergoog
force-pushed
the
no_sound_nullsafety
branch
2 times, most recently
from
adffa69 to
b3c2caa
Compare
gspencergoog
force-pushed
the
no_sound_nullsafety
branch
from
b3c2caa to
dca9403
Compare
gspencergoog
requested review from
jcollins-g and
srawlins
and removed request for
jcollins-g
jcollins-g
suggested changes
Mar 17, 2021
|
Added to the README.md, and I changed the name from compile-args to compile_args, to match the other tags. |
jcollins-g
approved these changes
Mar 17, 2021
README.md
Outdated
| @@ -289,6 +289,7 @@ dartdoc: | |||
| command: ["bin/drill.dart"] | |||
| setup_command: ["bin/setup.dart"] | |||
| description: "Puts holes in things." | |||
| compile_args: ["-no-sound-null-safety"] | |||
There was a problem hiding this comment.
probably should have two dashes
There was a problem hiding this comment.
In my head, it did. :-) Fixed.
parlough
approved these changes
Mar 17, 2021
jcollins-g
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started to convert a tool to null safety that had non-null-safe dependencies, and I realized that dartdoc will try and compile without the
--no-strong-null-safetyflag, and there was no way to specify it.This PR adds a mechanism for adding compile arguments to Dart-based tools, so that they can specify arguments like
--no-strong-null-safety(or any other args).