Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a foreach that seems to trigger the debugger #2695

Merged
merged 2 commits into from Jun 21, 2021

Conversation

jcollins-g
Copy link
Contributor

@jcollins-g jcollins-g commented Jun 21, 2021

Will file a SDK bug, but this forEach call seems to trigger on each iteration of the loop in the debugger now when debugging markdown_processor.dart. So, remove it to make debugging dartdoc less frustrating.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.06% when pulling 537acf8 on jcollins-g:remove-foreach into 20992ea on dart-lang:master.

@jcollins-g jcollins-g requested a review from srawlins June 21, 2021 21:20
@jcollins-g jcollins-g merged commit 701fd8f into dart-lang:master Jun 21, 2021
@jcollins-g jcollins-g deleted the remove-foreach branch June 21, 2021 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants