Skip to content

Include diff in highlightjs pack. #2718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2021
Merged

Include diff in highlightjs pack. #2718

merged 1 commit into from
Jul 19, 2021

Conversation

isoos
Copy link
Contributor

@isoos isoos commented Jul 13, 2021

Same content as in dart-lang/pub-dev#4945

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Jul 13, 2021
@devoncarew devoncarew requested a review from srawlins July 13, 2021 15:01
@isoos
Copy link
Contributor Author

isoos commented Jul 15, 2021

(merge at your convenience, I don't have the right to do that)

@isoos
Copy link
Contributor Author

isoos commented Jul 19, 2021

Kind ping: can anybody merge this?

@srawlins
Copy link
Member

I'm looking at dartdoc today; looking at CI failures and a P1, hopefully can merge today.

@srawlins
Copy link
Member

Sorry, I think you need a rebase.

@isoos
Copy link
Contributor Author

isoos commented Jul 19, 2021

Sorry, I think you need a rebase.

Done. CI is passing.

@srawlins srawlins merged commit f19b752 into dart-lang:master Jul 19, 2021
@isoos isoos deleted the diff branch July 19, 2021 22:03
@isoos
Copy link
Contributor Author

isoos commented Jul 19, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants