Update to analyzer 2.7.0, use createMockSdk() and FolderBasedDartSdk. #2845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcollins-g
approved these changes
Oct 25, 2021
|
|
||
| // The [MockSdk] only works in non-canonicalized paths, which include | ||
| // "C:\sdk", on Windows. However, dartdoc works almost exclusively with | ||
| // canonical paths ("c:\sdk"). Copy all MockSdk files to the canonicalized |
There was a problem hiding this comment.
Nice, this is no longer needed?
There was a problem hiding this comment.
Probably. Now createMockSdk writes into the given sdkRoot, and it is where we get this folder is where we should do any normalization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.