Skip to content

Fix left sidebar #3507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Fix left sidebar #3507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3820eeb
Fix left sidebar
srawlins Sep 29, 2023
6a75863
Fix static issues with latest Dart
srawlins Sep 29, 2023
eac1b22
Merge branch 'main' into fix-web-sidebar
srawlins Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/resources/docs.dart.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions lib/resources/docs.dart.js.map
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion web/docs.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ void initializeSidebars() {
}
final dataUsingBaseHref = body.dataset['using-base-href'];
if (dataUsingBaseHref == null) {
// This should never happen.
return;
}
var baseHref = '';
Expand All @@ -39,7 +40,7 @@ void initializeSidebars() {
return;
}
final aboveSidebarPath = mainContent.dataset['above-sidebar'];
final leftSidebar = document.querySelector('#dartdoc-sidebar-left-content');
final leftSidebar = document.querySelector('#dartdoc-sidebar-left');
if (aboveSidebarPath != null &&
aboveSidebarPath.isNotEmpty &&
leftSidebar != null) {
Expand Down
2 changes: 1 addition & 1 deletion web/sig.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
00BB1DC133C6B55B537C1F2BAA13AEAE
599BE3F0C7B0FCD52F532738D555B5AB