Skip to content

Conversation

srawlins
Copy link
Member

@srawlins srawlins commented Oct 6, 2023

I believe this fixes the sidebar issues in dart-lang/pub-dev#7058. CC @isoos

I've confirmed that (locally), this keeps working links in Flutter, a pub package, and the Dart SDK.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@isoos
Copy link
Collaborator

isoos commented Oct 6, 2023

Yes, this may fix it. I will also test it on Monday...

@srawlins srawlins requested a review from keertip October 6, 2023 20:11
@isoos
Copy link
Collaborator

isoos commented Oct 9, 2023

I have tested this on the fake pub-dev server, and can confirm that it fixes the issue. 🚀

@srawlins srawlins merged commit 5156398 into dart-lang:main Oct 9, 2023
@srawlins srawlins deleted the sanitizer branch October 9, 2023 23:57
@isoos
Copy link
Collaborator

isoos commented Oct 10, 2023

@srawlins: any plans on when this will be released?

@srawlins
Copy link
Member Author

@isoos are you working off of pub releases? We've been sitting on 7.0.0-wip for a while but we can pull the trigger. I need to get this latest code into Google internal to vet it, then I can cut a release.

@parlough
Copy link
Member

I guess I didn't fully follow the issue. Does this affect docs generated with dart doc or is it more specific to the replacements that pub makes? If it affects dart doc, might be worth releasing 7.0.0 and cherry-picking to 3.2 beta.

@srawlins
Copy link
Member Author

Yes, it should affect dart doc. I'll be curious to know if it is an existing issue in Dart 3.1.0.

@isoos
Copy link
Collaborator

isoos commented Oct 10, 2023

are you working off of pub releases?

Yes, we import published versions. It can be a prerelease if you wanted to.

@parlough
Copy link
Member

parlough commented Oct 10, 2023

I'll be curious to know if it is an existing issue in Dart 3.1.0.

It should be. The dartdoc version in 3.1 (e04a6b3) is after the sidebars were split out.

Edit: I tested locally with 3.1.3 and the issues are present.


I opened #3514 since I think it is worth the cherry-pick as some pages are quite broken. Not necessarily for 3.1 at the point, but definitely for 3.2 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants