-
Notifications
You must be signed in to change notification settings - Fork 130
Fix sidebar links for pub packages #3510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Yes, this may fix it. I will also test it on Monday... |
I have tested this on the fake pub-dev server, and can confirm that it fixes the issue. 🚀 |
@srawlins: any plans on when this will be released? |
@isoos are you working off of pub releases? We've been sitting on 7.0.0-wip for a while but we can pull the trigger. I need to get this latest code into Google internal to vet it, then I can cut a release. |
I guess I didn't fully follow the issue. Does this affect docs generated with |
Yes, it should affect |
Yes, we import published versions. It can be a prerelease if you wanted to. |
It should be. The dartdoc version in 3.1 (e04a6b3) is after the sidebars were split out. Edit: I tested locally with 3.1.3 and the issues are present. I opened #3514 since I think it is worth the cherry-pick as some pages are quite broken. Not necessarily for 3.1 at the point, but definitely for 3.2 :) |
I believe this fixes the sidebar issues in dart-lang/pub-dev#7058. CC @isoos
I've confirmed that (locally), this keeps working links in Flutter, a pub package, and the Dart SDK.
Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.