Skip to content

Conversation

srawlins
Copy link
Member

@srawlins srawlins commented Oct 19, 2023

  • Remove unnecessary complexity of an abstract class and an impl.
  • Remove unused staticElement.
  • In ModelNode, remove unused commentRefs field, and privatize element and resourceProvider.

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@srawlins srawlins requested a review from keertip October 19, 2023 19:03
@srawlins srawlins merged commit 41f0262 into dart-lang:main Oct 19, 2023
@srawlins srawlins deleted the model-comment-reference-simplify branch October 19, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants