Skip to content

Conversation

kallentu
Copy link
Member

@kallentu kallentu commented Dec 7, 2023

Relevant work for #3535.

Part 1 of removing markdown in Dartdoc. I added TODOs for the parts I'll include next CL, I prefer doing this in smaller chunks (for example, made a todo in RendererFactory because I'll do the larger removal later.).

  • Removed the format option.
  • For behaviour that relied on that flag result, defaulted to html.
  • Removed markdown specific tests.
  • Removed format option tests.

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@kallentu kallentu requested a review from srawlins December 7, 2023 22:31
Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Looks great

@kallentu kallentu merged commit 4317b06 into main Dec 8, 2023
@kallentu kallentu deleted the remove-markdown branch December 8, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants