Skip to content

update the markdown alert styles #3628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2024
Merged

update the markdown alert styles #3628

merged 1 commit into from
Jan 22, 2024

Conversation

devoncarew
Copy link
Member

@devoncarew devoncarew commented Jan 21, 2024


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@devoncarew
Copy link
Member Author

before:

Screenshot 2024-01-19 at 11 05 36 AM

after:

Screenshot 2024-01-21 at 1 22 20 PM

@devoncarew devoncarew requested a review from srawlins January 21, 2024 22:20
Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@devoncarew
Copy link
Member Author

@srawlins - separately, I noticed that the markdown blocks render pretty narrow - more narrow than the same type of content on dart.dev. We have the width limited currently to 700px:

Screenshot 2024-01-22 at 9 01 20 AM

We may want to expand that. I see that dart.dev is using a max-width of 960px for similar content.

@devoncarew devoncarew merged commit a1df7a1 into main Jan 22, 2024
@devoncarew devoncarew deleted the update_alert_styles branch January 22, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update the css of the new github alerts feature
2 participants