-
Notifications
You must be signed in to change notification settings - Fork 387
Prepare to release packages http/cronet_http/cupertino_http supporting request cancellation #1805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare to release packages http/cronet_http/cupertino_http supporting request cancellation #1805
Conversation
…g request cancellation
PR Health
Breaking changes
|
Package | Change | Current Version | New Version | Needed Version | Looking good? |
---|---|---|---|---|---|
cronet_http | Breaking | 1.4.0 | 1.5.0 | 2.0.0 Got "1.5.0" expected >= "2.0.0" (breaking changes) |
|
cupertino_http | Breaking | 2.2.0 | 2.3.0 | 3.0.0 Got "2.3.0" expected >= "3.0.0" (breaking changes) |
|
http | Breaking | 1.4.0 | 1.5.0 | 2.0.0 Got "1.5.0" expected >= "2.0.0" (breaking changes) |
This check can be disabled by tagging the PR with skip-breaking-check
.
Changelog Entry ✔️
Package | Changed Files |
---|
Changes to files need to be accounted for in their respective changelogs.
Coverage ✔️
File | Coverage |
---|
This check for test coverage is informational (issues shown here will not fail the PR).
API leaks ⚠️
The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
Package | Leaked API symbol | Leaking sources |
---|---|---|
cupertino_http | ncb.NSURLCache | cupertino_api.dart::URLCache native_cupertino_bindings.dart::NSURLCache::getSharedURLCache native_cupertino_bindings.dart::NSURLCache::setSharedURLCache::value native_cupertino_bindings.dart::NSURLCache::initWithMemoryCapacity_diskCapacity_diskPath_ native_cupertino_bindings.dart::NSURLCache::initWithMemoryCapacity_diskCapacity_directoryURL_ native_cupertino_bindings.dart::NSURLCache::init native_cupertino_bindings.dart::NSURLCache::new$ native_cupertino_bindings.dart::NSURLCache::allocWithZone_ native_cupertino_bindings.dart::NSURLCache::alloc native_cupertino_bindings.dart::NSURLCache::self$1 native_cupertino_bindings.dart::NSURLCache::retain native_cupertino_bindings.dart::NSURLCache::autorelease native_cupertino_bindings.dart::NSURLSessionConfiguration::URLCache native_cupertino_bindings.dart::NSURLSessionConfiguration::URLCache |
cupertino_http | NSURLRequest | native_cupertino_bindings.dart::NSURLCache::cachedResponseForRequest_::request native_cupertino_bindings.dart::NSURLRequest::requestWithURL_ native_cupertino_bindings.dart::NSURLRequest::requestWithURL_cachePolicy_timeoutInterval_ native_cupertino_bindings.dart::NSURLRequest::initWithURL_ native_cupertino_bindings.dart::NSURLRequest::initWithURL_cachePolicy_timeoutInterval_ native_cupertino_bindings.dart::NSURLRequest::init native_cupertino_bindings.dart::NSURLRequest::new$ native_cupertino_bindings.dart::NSURLRequest::allocWithZone_ native_cupertino_bindings.dart::NSURLRequest::alloc native_cupertino_bindings.dart::NSURLRequest::self$1 native_cupertino_bindings.dart::NSURLRequest::retain native_cupertino_bindings.dart::NSURLRequest::autorelease native_cupertino_bindings.dart::NSURLRequest::initWithCoder_ native_cupertino_bindings.dart::NSURLCache::storeCachedResponse_forRequest_::request native_cupertino_bindings.dart::NSURLCache::removeCachedResponseForRequest_::request |
cupertino_http | NSURLRequestAttribution | native_cupertino_bindings.dart::NSURLRequest::attribution native_cupertino_bindings.dart::NSURLRequestAttribution::NSURLRequestAttributionDeveloper native_cupertino_bindings.dart::NSURLRequestAttribution::NSURLRequestAttributionUser native_cupertino_bindings.dart::NSURLRequestAttribution::values native_cupertino_bindings.dart::NSURLRequestAttribution::fromValue |
cupertino_http | NSCachedURLResponse | native_cupertino_bindings.dart::NSURLCache::cachedResponseForRequest_ native_cupertino_bindings.dart::NSURLCache::storeCachedResponse_forRequest_::cachedResponse |
cupertino_http | ncb.NSURLSessionDelegate | cupertino_api.dart::URLSession::delegate |
cupertino_http | ncb.NSURLSessionConfiguration | cupertino_api.dart::URLSessionConfiguration native_cupertino_bindings.dart::NSURLSessionConfiguration::getDefaultSessionConfiguration native_cupertino_bindings.dart::NSURLSessionConfiguration::getEphemeralSessionConfiguration native_cupertino_bindings.dart::NSURLSessionConfiguration::backgroundSessionConfigurationWithIdentifier_ native_cupertino_bindings.dart::NSURLSessionConfiguration::init native_cupertino_bindings.dart::NSURLSessionConfiguration::new$ native_cupertino_bindings.dart::NSURLSessionConfiguration::allocWithZone_ native_cupertino_bindings.dart::NSURLSessionConfiguration::alloc native_cupertino_bindings.dart::NSURLSessionConfiguration::self$1 native_cupertino_bindings.dart::NSURLSessionConfiguration::retain native_cupertino_bindings.dart::NSURLSessionConfiguration::autorelease |
cupertino_http | SSLProtocol | native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMinimumSupportedProtocol native_cupertino_bindings.dart::SSLProtocol::kSSLProtocolUnknown native_cupertino_bindings.dart::SSLProtocol::kTLSProtocol1 native_cupertino_bindings.dart::SSLProtocol::kTLSProtocol11 native_cupertino_bindings.dart::SSLProtocol::kTLSProtocol12 native_cupertino_bindings.dart::SSLProtocol::kDTLSProtocol1 native_cupertino_bindings.dart::SSLProtocol::kTLSProtocol13 native_cupertino_bindings.dart::SSLProtocol::kDTLSProtocol12 native_cupertino_bindings.dart::SSLProtocol::kTLSProtocolMaxSupported native_cupertino_bindings.dart::SSLProtocol::kSSLProtocol2 native_cupertino_bindings.dart::SSLProtocol::kSSLProtocol3 native_cupertino_bindings.dart::SSLProtocol::kSSLProtocol3Only native_cupertino_bindings.dart::SSLProtocol::kTLSProtocol1Only native_cupertino_bindings.dart::SSLProtocol::kSSLProtocolAll native_cupertino_bindings.dart::SSLProtocol::values native_cupertino_bindings.dart::SSLProtocol::fromValue native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMinimumSupportedProtocol native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMaximumSupportedProtocol native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMaximumSupportedProtocol |
cupertino_http | tls_protocol_version_t | native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMinimumSupportedProtocolVersion native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_TLSv10 native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_TLSv11 native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_TLSv12 native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_TLSv13 native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_DTLSv10 native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_DTLSv12 native_cupertino_bindings.dart::tls_protocol_version_t::values native_cupertino_bindings.dart::tls_protocol_version_t::fromValue native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMinimumSupportedProtocolVersion native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMaximumSupportedProtocolVersion native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMaximumSupportedProtocolVersion |
cupertino_http | NSHTTPCookieStorage | native_cupertino_bindings.dart::NSURLSessionConfiguration::HTTPCookieStorage native_cupertino_bindings.dart::NSURLSessionConfiguration::HTTPCookieStorage |
cupertino_http | NSURLCredentialStorage | native_cupertino_bindings.dart::NSURLSessionConfiguration::URLCredentialStorage native_cupertino_bindings.dart::NSURLSessionConfiguration::URLCredentialStorage |
This check can be disabled by tagging the PR with skip-leaking-check
.
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files |
---|
no missing headers |
All source files should start with a license header.
Unrelated files missing license headers
Files |
---|
pkgs/http/example/main.dart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Publishing automation has failed here due to dart-lang/ecosystem#282 / dart-lang/ecosystem#168. You'll likely need to publish the flutter dependent ones by hand. You might be able to use the publishing automation for package:http
w/ a well-formed github release on this repo.
The http release seems to have worked. Publishing cronet and cupertino now. |
Revisions updated by `dart tools/rev_sdk_deps.dart`. ai (https://github.com/dart-lang/ai/compare/72a9283..6b4b2bc): 6b4b2bc 2025-08-11 Greg Spencer Add ability to filter analyzer results on a set of paths (dart-lang/ai#260) ecosystem (https://github.com/dart-lang/ecosystem/compare/4543c38..68ff911): 68ff911 2025-08-08 Moritz Make health file name configurable (dart-lang/ecosystem#364) http (https://github.com/dart-lang/http/compare/afda310..6656f15): 6656f15 2025-08-07 Brian Quinlan Remove http-beta dependency (dart-lang/http#1806) b661894 2025-08-07 Brian Quinlan Prepare to release packages http/cronet_http/cupertino_http supporting request cancellation (dart-lang/http#1805) i18n (https://github.com/dart-lang/i18n/compare/25cdb1b..c28ad5e): c28ad5ea 2025-08-08 Moritz Configure gemini (dart-lang/i18n#1002) web (https://github.com/dart-lang/web/compare/f3c960f..72cdd84): 72cdd84 2025-08-07 Kevin Moore Fix pkg:web CI badge (dart-lang/web#441) Change-Id: I98392b4c4ef037c6ffa8754e8fd2d9a9e17a643e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/444781 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Auto-Submit: Devon Carew <devoncarew@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
My plan is to release
package:http
and thenpackage:cronet_http
andpackage:cupertino_http
.Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.