Skip to content

Conversation

brianquinlan
Copy link
Collaborator

It is not clear what to do if callback methods throw.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions github-actions bot added the package:cupertino_http Issues related to package:cupertino_http label Aug 28, 2025
Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:cronet_http 1.5.0 already published at pub.dev
package:cupertino_http 2.4.0-wip WIP (no publish necessary)
package:http 1.5.0 already published at pub.dev
package:http2 3.0.0 ready to publish http2-v3.0.0
package:http_multi_server 3.2.2 already published at pub.dev
package:http_parser 4.1.2 already published at pub.dev
package:http_profile 0.1.1-wip WIP (no publish necessary)
package:ok_http 0.1.1-wip WIP (no publish necessary)
package:web_socket 1.0.1 already published at pub.dev
package:web_socket_channel 3.0.3 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Copy link

PR Health

Breaking changes ⚠️
Package Change Current Version New Version Needed Version Looking good?
cupertino_http Breaking 2.3.0 2.4.0-wip 3.0.0
Got "2.4.0-wip" expected >= "3.0.0" (breaking changes)
⚠️

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry
Package Changed Files
package:cupertino_http pkgs/cupertino_http/lib/src/cupertino_api.dart

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Coverage ⚠️
File Coverage
pkgs/cupertino_http/lib/src/cupertino_api.dart 💔 Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources
cupertino_http ncb.NSURLCache cupertino_api.dart::URLCache
native_cupertino_bindings.dart::NSURLCache::getSharedURLCache
native_cupertino_bindings.dart::NSURLCache::setSharedURLCache::value
native_cupertino_bindings.dart::NSURLCache::initWithMemoryCapacity
native_cupertino_bindings.dart::NSURLCache::initWithMemoryCapacity$1
native_cupertino_bindings.dart::NSURLCache::init
native_cupertino_bindings.dart::NSURLCache::new$
native_cupertino_bindings.dart::NSURLCache::allocWithZone
native_cupertino_bindings.dart::NSURLCache::alloc
native_cupertino_bindings.dart::NSURLCache::self$1
native_cupertino_bindings.dart::NSURLCache::retain
native_cupertino_bindings.dart::NSURLCache::autorelease
native_cupertino_bindings.dart::NSURLSessionConfiguration::URLCache
native_cupertino_bindings.dart::NSURLSessionConfiguration::URLCache
cupertino_http NSURLRequest native_cupertino_bindings.dart::NSURLCache::cachedResponseForRequest::request
native_cupertino_bindings.dart::NSURLRequest::requestWithURL
native_cupertino_bindings.dart::NSURLRequest::requestWithURL$1
native_cupertino_bindings.dart::NSURLRequest::initWithURL
native_cupertino_bindings.dart::NSURLRequest::initWithURL$1
native_cupertino_bindings.dart::NSURLRequest::init
native_cupertino_bindings.dart::NSURLRequest::new$
native_cupertino_bindings.dart::NSURLRequest::allocWithZone
native_cupertino_bindings.dart::NSURLRequest::alloc
native_cupertino_bindings.dart::NSURLRequest::self$1
native_cupertino_bindings.dart::NSURLRequest::retain
native_cupertino_bindings.dart::NSURLRequest::autorelease
native_cupertino_bindings.dart::NSURLRequest::initWithCoder
native_cupertino_bindings.dart::NSURLCache::storeCachedResponse::forRequest
native_cupertino_bindings.dart::NSURLCache::removeCachedResponseForRequest::request
cupertino_http NSURLRequestAttribution native_cupertino_bindings.dart::NSURLRequest::attribution
native_cupertino_bindings.dart::NSURLRequestAttribution::NSURLRequestAttributionDeveloper
native_cupertino_bindings.dart::NSURLRequestAttribution::NSURLRequestAttributionUser
native_cupertino_bindings.dart::NSURLRequestAttribution::values
native_cupertino_bindings.dart::NSURLRequestAttribution::fromValue
cupertino_http NSCachedURLResponse native_cupertino_bindings.dart::NSURLCache::cachedResponseForRequest
native_cupertino_bindings.dart::NSURLCache::storeCachedResponse::cachedResponse
cupertino_http ncb.NSURLSessionDelegate cupertino_api.dart::URLSession::delegate
cupertino_http ncb.NSURLSessionConfiguration cupertino_api.dart::URLSessionConfiguration
native_cupertino_bindings.dart::NSURLSessionConfiguration::getDefaultSessionConfiguration
native_cupertino_bindings.dart::NSURLSessionConfiguration::getEphemeralSessionConfiguration
native_cupertino_bindings.dart::NSURLSessionConfiguration::backgroundSessionConfigurationWithIdentifier
native_cupertino_bindings.dart::NSURLSessionConfiguration::init
native_cupertino_bindings.dart::NSURLSessionConfiguration::new$
native_cupertino_bindings.dart::NSURLSessionConfiguration::allocWithZone
native_cupertino_bindings.dart::NSURLSessionConfiguration::alloc
native_cupertino_bindings.dart::NSURLSessionConfiguration::self$1
native_cupertino_bindings.dart::NSURLSessionConfiguration::retain
native_cupertino_bindings.dart::NSURLSessionConfiguration::autorelease
cupertino_http SSLProtocol native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMinimumSupportedProtocol
native_cupertino_bindings.dart::SSLProtocol::kSSLProtocolUnknown
native_cupertino_bindings.dart::SSLProtocol::kTLSProtocol1
native_cupertino_bindings.dart::SSLProtocol::kTLSProtocol11
native_cupertino_bindings.dart::SSLProtocol::kTLSProtocol12
native_cupertino_bindings.dart::SSLProtocol::kDTLSProtocol1
native_cupertino_bindings.dart::SSLProtocol::kTLSProtocol13
native_cupertino_bindings.dart::SSLProtocol::kDTLSProtocol12
native_cupertino_bindings.dart::SSLProtocol::kTLSProtocolMaxSupported
native_cupertino_bindings.dart::SSLProtocol::kSSLProtocol2
native_cupertino_bindings.dart::SSLProtocol::kSSLProtocol3
native_cupertino_bindings.dart::SSLProtocol::kSSLProtocol3Only
native_cupertino_bindings.dart::SSLProtocol::kTLSProtocol1Only
native_cupertino_bindings.dart::SSLProtocol::kSSLProtocolAll
native_cupertino_bindings.dart::SSLProtocol::values
native_cupertino_bindings.dart::SSLProtocol::fromValue
native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMinimumSupportedProtocol
native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMaximumSupportedProtocol
native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMaximumSupportedProtocol
cupertino_http tls_protocol_version_t native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMinimumSupportedProtocolVersion
native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_TLSv10
native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_TLSv11
native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_TLSv12
native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_TLSv13
native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_DTLSv10
native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_DTLSv12
native_cupertino_bindings.dart::tls_protocol_version_t::values
native_cupertino_bindings.dart::tls_protocol_version_t::fromValue
native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMinimumSupportedProtocolVersion
native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMaximumSupportedProtocolVersion
native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMaximumSupportedProtocolVersion
cupertino_http NSHTTPCookieStorage native_cupertino_bindings.dart::NSURLSessionConfiguration::HTTPCookieStorage
native_cupertino_bindings.dart::NSURLSessionConfiguration::HTTPCookieStorage
cupertino_http NSURLCredentialStorage native_cupertino_bindings.dart::NSURLSessionConfiguration::URLCredentialStorage
native_cupertino_bindings.dart::NSURLSessionConfiguration::URLCredentialStorage

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/http/example/main.dart

This check can be disabled by tagging the PR with skip-license-check.

@brianquinlan brianquinlan merged commit f701e93 into dart-lang:master Sep 30, 2025
35 of 42 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Oct 1, 2025
…it_inspection_protocol

Revisions updated by `dart tools/rev_sdk_deps.dart`.

ai (https://github.com/dart-lang/ai/compare/901e2ce..ec5d6aa):
  ec5d6aa  2025-10-01  dependabot[bot]  Bump the github-actions group with 2 updates (dart-lang/ai#288)

http (https://github.com/dart-lang/http/compare/e0dadd1..2c53fa3):
  2c53fa3  2025-10-01  dependabot[bot]  Bump the github-actions group with 3 updates (dart-lang/http#1828)
  1b5103f  2025-10-01  Alex Li  [cronet_http] Upgrade `cronet-embedded` dependency version to support 16 KB page sizes (dart-lang/http#1824)
  f701e93  2025-09-29  Brian Quinlan  Remove obsolete TODO comment (dart-lang/http#1816)

i18n (https://github.com/dart-lang/i18n/compare/09627d2..34d1832):
  34d1832b  2025-10-01  Moritz  Fix casemapping on web (dart-lang/i18n#1013)
  914b0178  2025-10-01  dependabot[bot]  Bump actions/labeler from 5.0.0 to 6.0.1 in the github-actions group (dart-lang/i18n#1014)
  f171926e  2025-09-19  Moritz  Upgrade SDK in package:intl_translation (dart-lang/i18n#983)

shelf (https://github.com/dart-lang/shelf/compare/de91a5b..f30d650):
  f30d650  2025-10-01  dependabot[bot]  Bump the github-actions group with 3 updates (dart-lang/shelf#483)

test (https://github.com/dart-lang/test/compare/b99d556..a16f149):
  a16f1497  2025-10-01  dependabot[bot]  Bump the github-actions group with 5 updates (dart-lang/test#2547)

tools (https://github.com/dart-lang/tools/compare/2ef298e..19f91a0):
  19f91a03  2025-10-01  Morgan :)  Run file watcher symlink tests. (dart-lang/tools#2189)
  7929379b  2025-10-01  Morgan :)  Add test coverage for file watcher and symlinks. (dart-lang/tools#2178)
  d0e3edd1  2025-09-30  Morgan :)  Fix file watcher startup race on MacOS (dart-lang/tools#2176)
  36cefcee  2025-10-01  dependabot[bot]  Bump the github-actions group with 5 updates (dart-lang/tools#2188)
  08db1688  2025-10-01  Aleksey Garbarev  Fixing structure issue of nested lists indented by tabs (`#2172`) (dart-lang/tools#2173)
  16276f53  2025-09-30  Parker Lougheed  [markdown] Simplify deindentation logic for fenced code block lines (dart-lang/tools#2187)

vector_math (https://github.com/google/vector_math.dart/compare/3939545..a7b7e9c):
  a7b7e9c  2025-10-01  dependabot[bot]  Bump the github-actions group with 2 updates (google/vector_math.dart#352)

web (https://github.com/dart-lang/web/compare/0baaea4..816abcc):
  816abcc  2025-10-01  dependabot[bot]  Bump the github-actions group with 2 updates (dart-lang/web#473)

webkit_inspection_protocol (https://github.com/google/webkit_inspection_protocol.dart/compare/effa752..0f76858):
  0f76858  2025-10-01  dependabot[bot]  Bump the github-actions group across 1 directory with 3 updates (google/webkit_inspection_protocol.dart#135)

Change-Id: Id2cf6c1142aece53d531ca46122bb36a0fa2a34b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/452902
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:cupertino_http Issues related to package:cupertino_http
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants