Synchronously finalize headers #359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #351 An `async*` method is not started until after the stream has a listener, if a caller reads the headers before listening to the stream, they would see the value before they have been set. Move the header assignment and other finalization work to the wrapping method and keep the `async*` method handling only the stream content.
jakemac53
approved these changes
Jan 3, 2020
Yup, I'm trying to figure out the best way to do that. |
|
I added a test that fails before the change and passes after. I put the test in with the IO client tests since it's really an issue of the interaction between the IO client and PTAL |
jakemac53
approved these changes
Jan 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #351
An
async*method is not started until after the stream has a listener,if a caller reads the headers before listening to the stream, they would
see the value before they have been set. Move the header assignment and
other finalization work to the wrapping method and keep the
async*method handling only the stream content.