Create java http package #971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a new Dart package in pkgs called java_http using the Dart create command and the package template.
Remove the .gitignore file in java_http that was generated automatically by the Dart create command. Currently, we don't need a java_http specific .gitignore file because the .gitignore file in the parent directory contains all the required gitignore patterns.
Remove the analysis_options.yaml file in java_http that was generated automatically by the Dart create command. Then the Dart analyzer will use the analysis_options.yaml file in the parent directory.
Update the java_http README.md which was automatically generated by the Dart create command.
Add a comment to the java_http source files that were generated automatically by the Dart create command with the package template.
brianquinlan
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first pull request for the java_http package! 🎉 Relevant issue: #957.
In this PR I created a new Dart package called java_http using the Dart create command with the package template. This package was placed in the pkgs directory along with the other package:http clients. Functionality wise it doesn't do anything yet. It is the basic structure of a Dart package to build upon with future pull requests.
The main changes made to the code generated by the Dart create command were:
Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.