-
Notifications
You must be signed in to change notification settings - Fork 383
Java http send method #987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java http send method #987
Conversation
Connect to the url. Set the request headers and request method. Get the status code, reason phrase, response headers, response body and content length.
Hey @brianquinlan, I reverted the commits made to track down the reason the GitHub workflow was failing. It looks like the reason was that the Java client was trying to connect to I made a new commit to fix the bug by setting the Java client to prefer IPv6 using the system property: System.setProperty('java.net.preferIPv6Addresses'.toJString(), 'true'.toJString()); No changes were made to The following
Thank you for your help! |
Hey @brianquinlan,
The tests are passing when I run locally on my machine, but they are failing when run on the GitHub workflow 🤔
Context
This is a PR for the
java_http
GSoC '23 project 🌞.Relevant tracking issue: #957.
Purpose
The purpose of this PR is to improve the implementation of the
send
method ofJavaClient
(a subclass ofpackage:http
BaseClient
). This takes us closer to our goal ofJavaClient
passing all the tests in package:http_client_conformance_tests.Changes
In this PR we:
Connect to the URL.
Set the request headers to those given in
BaseRequest.headers
.Set the request method to the given method in
BaseRequest.method
.Send the request.
Retrieve the status code, reason phrase, response headers, content length and response body.
Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.