Add the ability to create directories #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoncarew
approved these changes
Apr 22, 2025
| /// | ||
| /// If the parent path does not exist, then `PathNotFoundException` is thrown. | ||
| void createDirectory(String path) { | ||
| throw UnsupportedError('createDirectory'); |
There was a problem hiding this comment.
Not necessarily for this PR, but if you create a utility method unsupportedError(String), then this impl. could be:
void createDirectory(String path) => unsupportedError('createDirectory');
There was a problem hiding this comment.
I'm talking with @lrhn now about whether this class should just be abstract/interface. If it lands that way, then all of these will disappear.
| // Calling `GetLastError` for the first time causes the `GetLastError` | ||
| // symbol to be loaded, which resets `GetLastError`. So make a harmless | ||
| // call before the value is needed. | ||
| win32.GetLastError(); |
There was a problem hiding this comment.
We may want to either:
- create a small 'primeLastError()' method in this library which does the same thing; this would let us avoid copying the 'why are we doing this' comment many times, or
- have a lastError() wrapper which accepts a closure; the wrapper can handle last error stuff, and the closure can do the actual work. this pattern may be less clear though
There was a problem hiding this comment.
Great idea! I'll go with the first idea, which will make it easy to remove when I fix this in the SDK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.