-
Notifications
You must be signed in to change notification settings - Fork 5
Use internal libc bindings #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
"AT_FDCWD", | ||
"AT_REMOVEDIR" | ||
] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: newline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The json pretty printer doesn't like newlines for some reason.
with: | ||
sdk: dev | ||
- run: dart pub get | ||
- run: dart run ffigen --config ffigen.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: As best practice, I've adopted having a tool/generate.dart
that does all the generators in the project with a --set-exit-if-changed
param. That way you can run all of them locally easily as well pre-commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll fix this in another PR
Use an internal
libc
shim instead ofpackage:stdlibc
.package:stdlibc
does not support Android, intel macOS and arm linux.For an explanation of the approach, see:
https://github.com/dart-lang/labs/pull/231/files#diff-d7066106d7deb29324ec6e4232d1dc307e2aa74333e15bc520a5b253c80e4fecR5
Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.