Skip to content

Use internal libc bindings #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
May 19, 2025
Merged

Use internal libc bindings #231

merged 30 commits into from
May 19, 2025

Conversation

brianquinlan
Copy link
Contributor

@brianquinlan brianquinlan commented May 15, 2025

Use an internal libc shim instead of package:stdlibc. package:stdlibc does not support Android, intel macOS and arm linux.

For an explanation of the approach, see:
https://github.com/dart-lang/labs/pull/231/files#diff-d7066106d7deb29324ec6e4232d1dc307e2aa74333e15bc520a5b253c80e4fecR5


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label May 15, 2025
@brianquinlan brianquinlan requested a review from dcharkes May 19, 2025 15:13
"AT_FDCWD",
"AT_REMOVEDIR"
]
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: newline

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The json pretty printer doesn't like newlines for some reason.

with:
sdk: dev
- run: dart pub get
- run: dart run ffigen --config ffigen.yaml

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: As best practice, I've adopted having a tool/generate.dart that does all the generators in the project with a --set-exit-if-changed param. That way you can run all of them locally easily as well pre-commit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix this in another PR

@brianquinlan brianquinlan merged commit 3c8c1e7 into dart-lang:main May 19, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:io_file type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants