Skip to content

Implement removeDirectoryTree on POSIX #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 4, 2025

Conversation

brianquinlan
Copy link
Contributor

@brianquinlan brianquinlan commented Jun 3, 2025

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link

github-actions bot commented Jun 3, 2025

Package publishing

Package Version Status Publish tag (post-merge)
package:appengine 0.13.11 ready to publish appengine-v0.13.11
package:gcloud 0.8.19 already published at pub.dev
package:googleapis_firestore_v1 0.1.0-wip WIP (no publish necessary)
package:native_synchronization 0.3.1 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@brianquinlan brianquinlan requested a review from devoncarew June 4, 2025 16:38
@@ -23,8 +23,11 @@ const _defaultDirectoryMode = 511; // => 0777 => rwxrwxrwx

const _nanosecondsPerSecond = 1000000000;

bool _isDotOrDotDot(Pointer<Char> s) => // ord('.') == 46
s[0] == 46 && ((s[1] == 0) || (s[1] == 46 && s[2] == 0));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @lrhn - it would be nice to be able to refer to character literals ( == 46 could change to something like == c'.').

@brianquinlan brianquinlan merged commit f896197 into dart-lang:main Jun 4, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants