Skip to content

Add the ability to test a FileSystem without using dart:io explicitly #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2025

Conversation

brianquinlan
Copy link
Contributor

The idea is that a non-platform FileSystem implementation (e.g. in-memory, WebDAV, etc.) should be testable using only itself as a reference.

I only updated only test to show what the change would look like conceptually.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

…itly

The idea is that a non-platform `FileSystem` implementation (e.g. in-memory, WebDAV, etc.) should be testable using only itself as a reference.

I only updated only test to show what the change would look like conceptually.
@brianquinlan brianquinlan requested a review from aam July 8, 2025 21:26

abstract interface class FileUtils {
String createTestDirectory(String testName);
void deleteDirectoryTree(String path);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline separator?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add it when I need it (and a bunch of other stuff ;-))

@brianquinlan brianquinlan merged commit 2f625ce into dart-lang:main Jul 9, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants