Skip to content

Conversation

brianquinlan
Copy link
Contributor

@brianquinlan brianquinlan commented Oct 8, 2025

Formatted YAML is more compact and less picky about commas.

--

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.

google-labs-jules bot and others added 3 commits October 8, 2025 01:23
…eated the new file.

This included adding the `yaml` dependency to `pubspec.yaml`, importing the `yaml` package in the Dart script, and replacing the `json.decode` call with `loadYaml` to parse the new YAML file.

I have converted the `functions.json` file to `functions.yaml`, creating the new file and moving the `prototype` field to the top of each function map.

I replaced the JSON parsing with YAML parsing and updated the file paths and comments accordingly.

The build scripts have been updated to use the new YAML files.

I have deleted the old JSON files, `constants.json` and `functions.json`, as they have been replaced by their YAML counterparts.
@brianquinlan brianquinlan requested a review from aam October 8, 2025 01:35
@brianquinlan brianquinlan merged commit b1faa8c into dart-lang:main Oct 8, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants