Correct part of syntax
#1615
Merged
Correct part of syntax
#1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dart-bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
May 5, 2021
Cf. dart-lang/language#1615. Resolves #45916. Change-Id: Id01cdd7496ea40183a15eed9d3561ab3c21819c0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/198400 Reviewed-by: Lasse R.H. Nielsen <lrn@google.com> Commit-Queue: Erik Ernst <eernst@google.com>
eernstg
force-pushed
the
specify_part_of_uri_may21
branch
from
cbe05f4
to
0f179dc
Compare
|
@lrhn, this one is tiny. ;) |
|
@lrhn, do you have any specific worries about this change? |
lrhn
approved these changes
May 19, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny bug fix, cf. dart-lang/sdk#45916:
The specification currently allows for a
part ofdirective where the enclosing library is specified using<identifier> ('.' <identifier>)*, but not using<uri>. The latter is intended to work, and it has been working in all tools for a while, and this PR just brings the specification up to date.