Grammar fix: Add support for covariant late final instance variables #1728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrhn
approved these changes
Jul 9, 2021
dart-bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jul 12, 2021
Change Dart.g to be in sync with the language specification after dart-lang/language#1728. Change-Id: I7587da87ec6a0300810949a34e90af5560cbeac0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206261 Commit-Queue: Erik Ernst <eernst@google.com> Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current grammar does not allow an instance variable declaration with modifiers
covariant late final. However, that should be allowed, because a late final variable does have a setter. This PR adds a grammar rule to enable that.There is no implementation effort, because this construct is already used in
language/nnbd/late/covariant_instance_field_test.dart, and that test succeeds on all configurations, cf. https://dart-ci.firebaseapp.com/current_results/#/filter=language/nnbd/late/covariant_instance_field_test&showAll.