Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change method override inference to use combined member signature #975

Merged
merged 4 commits into from
Jun 4, 2020

Conversation

eernstg
Copy link
Member

@eernstg eernstg commented May 19, 2020

No description provided.

Copy link
Member

@leafpetersen leafpetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the setter/getter/field section may need update as well, but otherwise LGTM.

resources/type-system/inference.md Outdated Show resolved Hide resolved
resources/type-system/inference.md Show resolved Hide resolved
resources/type-system/inference.md Show resolved Hide resolved
@leafpetersen
Copy link
Member

What's the status of this?

@eernstg
Copy link
Member Author

eernstg commented Jun 3, 2020

Updated the getters/setters section, PTAL.

@eernstg eernstg force-pushed the spec_override_inference_may20 branch from aaa1c6c to f151fc7 Compare June 4, 2020 08:40
@eernstg eernstg merged commit 123ba36 into master Jun 4, 2020
@eernstg eernstg deleted the spec_override_inference_may20 branch June 8, 2020 10:00
dart-bot pushed a commit to dart-lang/sdk that referenced this pull request Jun 12, 2020
dart-lang/language#975

Change-Id: I5cec14a384b124a29dcd5adac0f0be6e5214cc9e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151044
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
dart-bot pushed a commit to dart-lang/sdk that referenced this pull request Jun 15, 2020
dart-lang/language#975

Change-Id: I8ecd191efa84f17d36ea09ef1db33a401c67fda3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151093
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants