-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change method override inference to use combined member signature #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
commented
May 19, 2020
leafpetersen
approved these changes
May 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the setter/getter/field section may need update as well, but otherwise LGTM.
What's the status of this? |
Updated the getters/setters section, PTAL. |
leafpetersen
approved these changes
Jun 3, 2020
eernstg
force-pushed
the
spec_override_inference_may20
branch
from
June 4, 2020 08:40
aaa1c6c
to
f151fc7
Compare
dart-bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jun 12, 2020
dart-lang/language#975 Change-Id: I5cec14a384b124a29dcd5adac0f0be6e5214cc9e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151044 Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Paul Berry <paulberry@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
dart-bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jun 15, 2020
dart-lang/language#975 Change-Id: I8ecd191efa84f17d36ea09ef1db33a401c67fda3 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151093 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.