Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SecurityLintCode instead of deprecated SecurityLintCodeWithUniqueName #2675

Merged
merged 1 commit into from
May 26, 2021
Merged

Use SecurityLintCode instead of deprecated SecurityLintCodeWithUniqueName #2675

merged 1 commit into from
May 26, 2021

Conversation

scheglov
Copy link
Contributor

I want to remove SecurityLintCodeWithUniqueName.

@google-cla google-cla bot added the cla: yes label May 26, 2021
@scheglov scheglov requested review from pq and bwilkerson May 26, 2021 02:21
@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 94.033% when pulling d6c3a99 on scheglov:replace-with-SecurityLintCode into ce5c72d on dart-lang:master.

pq
pq approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pq pq merged commit 43df75b into dart-lang:master May 26, 2021
@scheglov scheglov deleted the replace-with-SecurityLintCode branch May 26, 2021 16:26
dart-bot pushed a commit to dart-lang/sdk that referenced this pull request Jun 3, 2021
@scheglov
Remove deprecated LintCodeWithUniqueName and SecurityLintCodeWithUniq…
e2178ce 
…ueName.

These are not used by the latest linter, and are not API.
dart-lang/linter#2675

Change-Id: I9877e01681c573dfff1bda1c8cd6424e7eff1f4a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/202320
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwilkerson bwilkerson bwilkerson approved these changes

@pq pq pq approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scheglov @coveralls @pq @bwilkerson