Skip to content

[native_assets_cli] Add base path for user-defines - fix #2210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025

Conversation

dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented Apr 16, 2025

Copy link

github-actions bot commented Apr 16, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
native_assets_cli Breaking 0.15.0 0.16.0-wip 0.16.0 ✔️
API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

Copy link

auto-submit bot commented Apr 16, 2025

autosubmit label was removed for dart-lang/native/2210, because - The status or check suite health / changelog / run changelog health check has failed. Please fix the issues identified (or deflake) before re-applying this label.

Copy link

auto-submit bot commented Apr 16, 2025

autosubmit label was removed for dart-lang/native/2210, because - The status or check suite health / changelog / run changelog health check has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit label Apr 16, 2025
@dcharkes dcharkes merged commit 49a8912 into main Apr 16, 2025
64 of 65 checks passed
@dcharkes dcharkes deleted the user-defines-base-path-fix branch April 16, 2025 12:44
@coveralls
Copy link

Coverage Status

coverage: 75.734% (-0.02%) from 75.75%
when pulling 419e414 on user-defines-base-path-fix
into 222eb98 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants