[ffigen] [jnigen] Unify typesetting of FFIgen and JNIgen #2693
+147
−143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
github-actions
bot
added
type-infra
goderbauer
changed the title
PR HealthBreaking changes ✔️
This check can be disabled by tagging the PR with
API leaks
|
| Package | Leaked API symbol | Leaking sources |
|---|---|---|
| objective_c | _FinalizablePointer | internal.dart::_ObjCReference::new::_finalizable |
This check can be disabled by tagging the PR with skip-leaking-check.
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
| Files |
|---|
| no missing headers |
All source files should start with a license header.
Unrelated files missing license headers
| Files |
|---|
| pkgs/objective_c/lib/src/ns_input_stream.dart |
This check can be disabled by tagging the PR with skip-license-check.
dcharkes
approved these changes
Oct 13, 2025
| @@ -1,5 +1,5 @@ | |||
| name: pdf_info | |||
| description: Dart standalone example using jnigen PDFBox bindings. | |||
| description: Dart standalone example using JNIgen PDFBox bindings. | |||
There was a problem hiding this comment.
JNIgenned?
PDFBox bindings generated by JNIgen?
PDFBox bindings?
HosseinYousefi
approved these changes
Oct 13, 2025
|
FFIgen and JNIgen over |
|
Resolved via #2695. |
liamappelbe
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #2691 (comment).
This changes the typesetting of our product names to be FFIgen and JNIgen consistently throughout the code base. It eliminates type settings like
ffigen/jnigenor jnigen/ffigen.