Skip to content

Conversation

goderbauer
Copy link
Contributor

@goderbauer goderbauer commented Oct 13, 2025

This example was introduced in the "Getting Started" section of the readme, see #2691. This PR adds that example to the example subdirectory so we can link to it from the readme. People who get stuck can then simply checkout the example to figure out what they did wrong.

TODO: Update readme after #2691 lands to link to this.

Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/objective_c/lib/src/ns_input_stream.dart

This check can be disabled by tagging the PR with skip-license-check.

@goderbauer
Copy link
Contributor Author

Failure seems to be coming from a missing dart pub get in the new example.

@liamappelbe where do we run that for the other examples?

publish_to: none

environment:
sdk: ^3.10.0-285.0.dev
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we require this SDK version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, this was just generated by dart create. I updated it to match what the other examples do.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be running analyze etc against stable as well, so that should have made the CI red.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That failure was probably hidden by the failure caused by not running dart pub get at all in this new example. See my comment above.

@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Oct 14, 2025
@coveralls
Copy link

coveralls commented Oct 14, 2025

Coverage Status

coverage: 86.719% (-3.0%) from 89.749%
when pulling 815b2c8 on goderbauer:ffigenexample
into c2cad10 on dart-lang:main.

@goderbauer goderbauer merged commit f3d890c into dart-lang:main Oct 14, 2025
42 of 43 checks passed
@goderbauer goderbauer deleted the ffigenexample branch October 14, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package:ffigen package:jnigen type-infra A repository infrastructure change or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants