-
Notifications
You must be signed in to change notification settings - Fork 80
[ffigen] add example from readme as real example for reference #2697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR HealthBreaking changes ✔️
This check can be disabled by tagging the PR with Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
This check can be disabled by tagging the PR with |
Failure seems to be coming from a missing @liamappelbe where do we run that for the other examples? |
pkgs/ffigen/example/add/pubspec.yaml
Outdated
publish_to: none | ||
|
||
environment: | ||
sdk: ^3.10.0-285.0.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we require this SDK version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, this was just generated by dart create
. I updated it to match what the other examples do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be running analyze etc against stable as well, so that should have made the CI red.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That failure was probably hidden by the failure caused by not running dart pub get
at all in this new example. See my comment above.
2fe147b
to
43c449d
Compare
43c449d
to
815b2c8
Compare
This example was introduced in the "Getting Started" section of the readme, see #2691. This PR adds that example to the
example
subdirectory so we can link to it from the readme. People who get stuck can then simply checkout the example to figure out what they did wrong.TODO: Update readme after #2691 lands to link to this.