Do not retry (or panic in logs) on upload exceptions when the version is no longer scheduled for analysis. #8196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasfj
reviewed
Oct 29, 2024
jonasfj
reviewed
Oct 30, 2024
…ger expected to complete.
…ing token is detected.
jonasfj
reviewed
Nov 1, 2024
Comment on lines
1177
to
1192
| final versionState = state.versions![version]; | ||
| if (versionState == null) { | ||
| // check if the task was aborted | ||
| final abortedToken = | ||
| state.abortedTokens?.firstWhereOrNull((t) => t.token == token); | ||
| if (abortedToken != null && abortedToken.expires.isBefore(clock.now())) { | ||
| throw TaskAbortedException('$package/$version has been aborted.'); | ||
| } | ||
| // otherwise throw a generic not found error | ||
| throw NotFoundException.resource('$package/$version'); | ||
| } | ||
|
|
||
| // Check the secret token | ||
| if (!versionState.isAuthorized(token)) { | ||
| throw AuthenticationException.authenticationRequired(); | ||
| } |
There was a problem hiding this comment.
This is vulnerable to timing attacks!
I'd suggest adding an isAuthorized method to AbortedTokenInfo object.
Also versionState != null doesn't imply that the token couldn't be aborted.
I'd suggest:
- Always check
abortedTokens, ideally always compare all of them (not just the first, because we want fixed time behavior) - Then check
versionState.isAuthorized
Co-authored-by: Jonas Finnemann Jensen <jopsen@gmail.com>
Co-authored-by: Jonas Finnemann Jensen <jopsen@gmail.com>
Co-authored-by: Jonas Finnemann Jensen <jopsen@gmail.com>
Co-authored-by: Jonas Finnemann Jensen <jopsen@gmail.com>
jonasfj
reviewed
Nov 6, 2024
| .map( | ||
| (vs) => AbortedTokenInfo( | ||
| token: vs.secretToken!, | ||
| expires: vs.scheduled.add(maxTaskExecutionTime), |
There was a problem hiding this comment.
We should have stored scheduled instead of expires, not that it matters more, but it would have been 10% more canonical.
Anyways, I don't think it matters :D
There was a problem hiding this comment.
We could replace it, but I'm not sure it is worth it...
jonasfj
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.