Skip to content

Fix h3 issue on landing page. #8477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Fix h3 issue on landing page. #8477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions app/lib/frontend/templates/views/landing/mini_list.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,17 @@ d.Node _title(String sectionTag, PackageView p) {
return d.a(
classes: ['mini-list-item-title'],
href: urls.pkgPageUrl(p.name),
attributes: {'data-ga-click-event': 'landing-$sectionTag-card-title'},
child: d.h3(text: p.name),
attributes: {
'data-ga-click-event': 'landing-$sectionTag-card-title',
},
child: d.span(
classes: ['mini-list-item-title-text'],
text: p.name,
attributes: {
'role': 'heading',
'aria-level': '2',
},
),
);
}

Expand Down
6 changes: 3 additions & 3 deletions app/test/frontend/golden/landing_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ <h1 class="home-block-title">Flutter Favorites</h1>
<div class="mini-list">
<div class="mini-list-item">
<a class="mini-list-item-title" href="/packages/flutter_titanium" data-ga-click-event="landing-flutter-favorites-card-title">
<h3>flutter_titanium</h3>
<span class="mini-list-item-title-text" role="heading" aria-level="2">flutter_titanium</span>
</a>
<div class="mini-list-item-body">
<p class="mini-list-item-description">flutter_titanium is awesome</p>
Expand All @@ -153,7 +153,7 @@ <h1 class="home-block-title">Most popular packages</h1>
<div class="mini-list">
<div class="mini-list-item">
<a class="mini-list-item-title" href="/packages/neon" data-ga-click-event="landing-most-popular-card-title">
<h3>neon</h3>
<span class="mini-list-item-title-text" role="heading" aria-level="2">neon</span>
</a>
<div class="mini-list-item-body">
<p class="mini-list-item-description">neon is awesome</p>
Expand All @@ -167,7 +167,7 @@ <h3>neon</h3>
</div>
<div class="mini-list-item">
<a class="mini-list-item-title" href="/packages/oxygen" data-ga-click-event="landing-most-popular-card-title">
<h3>oxygen</h3>
<span class="mini-list-item-title-text" role="heading" aria-level="2">oxygen</span>
</a>
<div class="mini-list-item-body">
<p class="mini-list-item-description">oxygen is awesome</p>
Expand Down
2 changes: 1 addition & 1 deletion pkg/_pub_shared/lib/validation/html/html_validation.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ void validateHtml(Node root) {
}

// "role"="<role>" attributes should be on interactive components
final allowedForRole = {'a', 'form'};
final allowedForRole = {'a', 'form', 'span'};
for (final elem in querySelectorAll('[role]')) {
final tag = elem.localName!;
final role = elem.attributes['role'];
Expand Down
3 changes: 2 additions & 1 deletion pkg/web_css/lib/src/_home.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,8 @@
}

.mini-list-item-title {
> h3 {
> .mini-list-item-title-text {
display: block;
color: var(--pub-home_card_title-text-color);
font-size: 20px;
// Needs to be slightly more than 1.2, otherwise the bottom
Expand Down
Loading