Skip to content

Replace drop-shadow with only borders in dark mode. #8489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Replace drop-shadow with only borders in dark mode. #8489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/web_css/lib/src/_home.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,16 +106,16 @@
}

.mini-list-item {
@include variables.elevated-content-border;

background: var(--pub-neutral-bgColor);
border-radius: 4px;
box-shadow: 0px 2px 7px 0px var(--pub-home_card-box_shadow-color);
padding: 28px 30px 30px; // title's top gap is about 2px (30-2 => 28)
margin-bottom: 10px;
min-height: 100px;

&:hover {
background: var(--pub-neutral-hover-bgColor);
box-shadow: 0px 4px 9px 0px var(--pub-home_card_hover-box_shadow-color);

@media (min-width: variables.$device-desktop-min-width) {
.mini-list-item-body {
Expand Down
18 changes: 18 additions & 0 deletions pkg/web_css/lib/src/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,24 @@
}
}

@mixin elevated-content-border {
.light-theme & {
box-shadow: 0px 2px 7px 0px var(--pub-home_card-box_shadow-color);

&:hover {
box-shadow: 0px 4px 9px 0px var(--pub-home_card_hover-box_shadow-color);
}
}

.dark-theme & {
border: 1px solid var(--pub-home_card-box_shadow-color);

&:hover {
border-color: var(--pub-home_card_hover-box_shadow-color);
}
}
}

$device-desktop-min-width: 641px;
$device-mobile-max-width: 640px;
$device-tablet-max-width: 979px;
Expand Down
Loading