Skip to content

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Jan 24, 2025

  • follow-up to Refactor proposal: use unnamed callback function in with*HttpPubApiClient methods. #8490
  • the Http part of the method name is not that relevant (since IIRC we no longer have the non-HTTP version)
  • replacing it with Retry to follow the pattern of other similar helper methods
  • renamed bearerToken -> authToken as the bearer part is only a technical detail
  • renamed experimental -> experiments as we pass on the list of experiments and not the experimental cookie value

@isoos isoos requested review from jonasfj and sigurdm January 24, 2025 17:08
@isoos isoos merged commit a5dc0d2 into dart-lang:master Jan 27, 2025
31 checks passed
@isoos isoos deleted the refactor-api-client branch January 27, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants