Skip to content

Increase contrast of pub detail tags in dark mode #8519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Increase contrast of pub detail tags in dark mode #8519

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e841b17
Increase contrast of pub detail tags in dark mode
parlough Feb 3, 2025
7d17085
remove nipponUltraBlue
isoos Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/web_css/lib/src/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,14 +151,14 @@
--pub-color-darkBlack: #121317;
--pub-color-darkGunmetal: #242b32;
--pub-color-darkGray: #2f3034; /* derived from dark black by making it lighter */
--pub-color-nipponUltraBlue: #23607f;
--pub-color-darkSteelBlue: #144466;

--pub-neutral-bgColor: var(--pub-color-darkBlack);
--pub-neutral-borderColor: var(--pub-color-darkGunmetal);
--pub-neutral-textColor: var(--dash-surface-fgColor);
--pub-neutral-hover-bgColor: var(--pub-color-darkGray);
--pub-inset-bgColor: var(--pub-color-darkGunmetal);
--pub-selected-bgColor: var(--pub-color-nipponUltraBlue);
--pub-selected-bgColor: var(--pub-color-darkSteelBlue);

// Note: these colors are copied from GitHub styles
--pub-markdown-alert-note: #0969da; // accent-emphasis from GitHub
Expand Down Expand Up @@ -189,7 +189,7 @@
--pub-sort_control_hover-text-color: var(--pub-neutral-textColor);
--pub-sort_control_selected-text-color: var(--pub-neutral-textColor);
--pub-tag_simplebadge-text-color: var(--pub-neutral-textColor);
--pub-tag_sdkbadge-separator-color: var(--pub-neutral-textColor);
--pub-tag_sdkbadge-separator-color: #226699;
--pub-tag_sdkbadge-text-color: var(--pub-neutral-textColor);

--pub-downloads-chart-frame-color: #55585a;
Expand Down
Loading