Skip to content

Increase search instance's memory (and core count). #8833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Jun 25, 2025

The production search instances report about 6.5-7 GB memory being used, and about 12 GB maximum memory usage, which is happening when the new search isolate is being loaded while the old one is still active. This is very close to the 12.6 GB limit, and the new search isolate also adds a nontrivial amount of memory.

I think we should increase the memory, which can only be done if we also increase the CPU count. This is a must if we must keep the current experiment with the fast-lane search isolate, but even if we roll that back, I think we should increase the memory as we are close to the allocated threshold.

Note: I'll spend some time on the memory usage later, I think we have a few things to optimize (or remove) there.

@isoos isoos requested review from szakarias and sigurdm June 25, 2025 11:09
@isoos isoos merged commit 95b4920 into dart-lang:master Jun 26, 2025
31 checks passed
@isoos isoos deleted the search-memo branch June 26, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants