Skip to content

Reduce log level of pub_worker proxy-related failures. #8976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2025
Merged

Reduce log level of pub_worker proxy-related failures. #8976

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions pkg/pub_worker/lib/src/analyze.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,17 @@ Future<void> analyze(Payload payload) async {
);
}

void warnTaskError(Exception e, StackTrace st) {
_log.warning(
'Failed to process ${payload.package} / ${p.version}',
e,
st,
);
}

void shoutTaskError(Object e, StackTrace st) {
_log.shout(
'failed to process ${payload.package} / ${p.version}',
'Failed to process ${payload.package} / ${p.version}',
e,
st,
);
Expand Down Expand Up @@ -120,13 +128,17 @@ Future<void> analyze(Payload payload) async {
late final map = e.bodyAsJson();
late final error = map['error'];
late final code = map['code'] ?? (error is Map ? error['code'] : null);
if (e.status == 400 && code is String && code == 'TaskAborted') {
if (e.status >= 500) {
warnTaskError(e, st);
} else if (e.status == 400 && code is String && code == 'TaskAborted') {
warnTaskAborted(e, st);
} else {
shoutTaskError(e, st);
}
} on ApiResponseException catch (e, st) {
if (e.status == 400 && e.code == 'TaskAborted') {
if (e.status >= 500) {
warnTaskError(e, st);
} else if (e.status == 400 && e.code == 'TaskAborted') {
warnTaskAborted(e, st);
} else {
shoutTaskError(e, st);
Expand Down