Add default upper bound Dart SDK constraint override from 2.0.0 -> 2.0.0-dev.infinity #1704
Conversation
lib/src/pubspec.dart
Outdated
| return true; | ||
| break; | ||
| case "quiet": | ||
| warnAboutPreReleaseTwoDotZeroSdkOverrides = false; |
There was a problem hiding this comment.
PM nit...
This makes me sad. I hate mutable top-level things.
Could their be a private field w/ an enum type and then two public bool properties that just key off it?
There was a problem hiding this comment.
done (didn't use an enum though)
test/version_solver_test.dart
Outdated
| // Log output should mention the PUB_ALLOW_RELEASE_SDK environment | ||
| // variable and mention the foo and bar packages specifically. | ||
| output: allOf(contains('PUB_ALLOW_PRERELEASE_SDK'), | ||
| anyOf(contains('foo, bar'), contains('bar, foo'))), |
There was a problem hiding this comment.
Or you could just sort it? Might make it easier to parse for the user, too...
There was a problem hiding this comment.
Or just:
allOf(contains('PUB_ALLOW_PRERELEASE_SDK'), contains('foo'), contains('bar'))There was a problem hiding this comment.
went ahead and sorted it since this is actually a long list in many cases so its a bit easier to parse
lib/src/entrypoint.dart
Outdated
| .join(', '); | ||
| if (overriddenPackages.isNotEmpty) { | ||
| log.message(log.yellow( | ||
| 'Overriding Dart SDK constraint from <2.0.0 to <2.0.0-dev.infinity' |
lib/src/pubspec.dart
Outdated
| final VersionRange _defaultUpperBoundSdkConstraint = | ||
| new VersionConstraint.parse("<2.0.0"); | ||
|
|
||
| /// The upper bound contraint that matches the dev sdk. |
lib/src/pubspec.dart
Outdated
| }(); | ||
|
|
||
| /// Whether or not to warn about pre-release sdk overrides. | ||
| bool warnAboutPreReleaseTwoDotZeroSdkOverrides = true; |
There was a problem hiding this comment.
This returns the wrong value if it's read before allowPreReleaseTwoDotZeroSdk is. Like @kevmoo suggests, you probably want a single lazy-initialized backing field and then two bool getters.
test/version_solver_test.dart
Outdated
| // Log output should mention the PUB_ALLOW_RELEASE_SDK environment | ||
| // variable and mention the foo and bar packages specifically. | ||
| output: allOf(contains('PUB_ALLOW_PRERELEASE_SDK'), | ||
| anyOf(contains('foo, bar'), contains('bar, foo'))), |
There was a problem hiding this comment.
Or just:
allOf(contains('PUB_ALLOW_PRERELEASE_SDK'), contains('foo'), contains('bar'))
test/version_solver_test.dart
Outdated
| }); | ||
|
|
||
| test( | ||
| 'pub doesn\'t log about pre-release sdk overrides if ' |
There was a problem hiding this comment.
Nit: I think it's a little cleaner to use a double-quoted string instead of escaping the apostrophe.
Also introduces the PUB_ALLOW_PRERELEASE_SDK environment variable which can override this behavior. Valid values are
true(default),false, andquiet(true but no log message about the override).Fixes #1692