Reenable the common front-end in dart2js by creating a .packages file #1829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nex3
approved these changes
Mar 15, 2018
| await compiler.compile( | ||
| p.toUri(entrypoint), | ||
| provider.libraryRoot, | ||
| p.toUri(appendSlash(packageRoot)), |
There was a problem hiding this comment.
Are we still using appendSlash()? If not, can you delete it?
|
Sounds good. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: the
.packagesfile is not available as an asset, so it wont be emitted in the output build folder. If you want to make it a asset, could you please give me some hints as to where/how I should do so?