Revert "Refactoring resolution of local access and unqualified access…

… of statics" This reverts commit 58896b7. BUG= Review URL: https://codereview.chromium.org//1160313006
dart-lang · Jun 8, 2015 · 1807369 · 1807369
1 parent a1b6306
commit 1807369
Show file tree

Hide file tree

Showing 11 changed files with 83 additions and 496 deletions.
diff --git a/pkg/compiler/lib/src/enqueue.dart b/pkg/compiler/lib/src/enqueue.dart
@@ -546,8 +546,7 @@ abstract class Enqueuer {
    */
   void registerStaticUse(Element element) {
     if (element == null) return;
-    assert(invariant(element, element.isDeclaration,
-        message: "Element ${element} is not the declaration."));
+    assert(invariant(element, element.isDeclaration));
     if (Elements.isStaticOrTopLevel(element) && element.isField) {
       universe.registerStaticFieldUse(element);
     }

diff --git a/pkg/compiler/lib/src/helpers/trace.dart b/pkg/compiler/lib/src/helpers/trace.dart
@@ -53,12 +53,6 @@ void _trace(String message, {bool condition(String stackTrace), int limit,
   }
 }
 
-/// Creates a function to use as an `condition` argument in [trace] that filters
-/// stack traces that contains any of the [exceptions].
-traceExceptions(List<String> exceptions) {
-  return (String stackTrace) => !exceptions.any(stackTrace.contains);
-}
-
 /// Function signature of [traceAndReport].
 typedef void TraceAndReport(Compiler compiler, Spannable node, String message,
                             {bool condition(String stackTrace), int limit,

diff --git a/pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart b/pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart
@@ -1695,26 +1695,6 @@ class SimpleTypeInferrerVisitor<T>
     return handleStaticFieldOrGetterInvoke(node, getter);
   }
 
-  @override
-  T visitStaticSetterInvoke(
-      ast.Send node,
-      MethodElement setter,
-      ast.NodeList arguments,
-      CallStructure callStructure,
-      _) {
-    return handleInvalidStaticInvoke(node);
-  }
-
-  @override
-  T visitTopLevelSetterInvoke(
-      ast.Send node,
-      MethodElement setter,
-      ast.NodeList arguments,
-      CallStructure callStructure,
-      _) {
-    return handleInvalidStaticInvoke(node);
-  }
-
   @override
   T visitUnresolvedInvoke(
       ast.Send node,
@@ -1890,22 +1870,6 @@ class SimpleTypeInferrerVisitor<T>
     return handleStaticGetterGet(node, getter);
   }
 
-  @override
-  T visitStaticSetterGet(
-      ast.Send node,
-      MethodElement setter,
-      _) {
-    return types.dynamicType;
-  }
-
-  @override
-  T visitTopLevelSetterGet(
-      ast.Send node,
-      MethodElement setter,
-      _) {
-    return types.dynamicType;
-  }
-
   @override
   T visitUnresolvedGet(
       ast.Send node,