Skip to content

Commit 1b04691

Browse files
aartbikcommit-bot@chromium.org
authored andcommitted
[vm/checker] Keep private method order consistent with header
Rationale: Use a consistent order for methods in header and CC. Change-Id: Idf887346aea402bae1a9804183f49ef10b2e04c7 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112272 Reviewed-by: Samir Jindel <sjindel@google.com> Commit-Queue: Aart Bik <ajcbik@google.com>
1 parent a3f5dfc commit 1b04691

File tree

1 file changed

+13
-17
lines changed

1 file changed

+13
-17
lines changed

runtime/vm/compiler/backend/flow_graph_checker.cc

Lines changed: 13 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -349,23 +349,6 @@ void FlowGraphChecker::VisitConstant(ConstantInstr* constant) {
349349
// ASSERT(constant->GetBlock() == flow_graph_->graph_entry());
350350
}
351351

352-
void FlowGraphChecker::VisitInstanceCall(InstanceCallInstr* instr) {
353-
const Function& function = flow_graph_->function();
354-
355-
// Force-optimized functions may not have instance calls inside them because
356-
// we do not reset ICData for these.
357-
ASSERT(!function.ForceOptimize());
358-
}
359-
360-
void FlowGraphChecker::VisitPolymorphicInstanceCall(
361-
PolymorphicInstanceCallInstr* instr) {
362-
const Function& function = flow_graph_->function();
363-
364-
// Force-optimized functions may not have instance calls inside them because
365-
// we do not reset ICData for these.
366-
ASSERT(!function.ForceOptimize());
367-
}
368-
369352
void FlowGraphChecker::VisitPhi(PhiInstr* phi) {
370353
// Make sure the definition of each input value of a Phi dominates
371354
// the corresponding incoming edge, as defined by order.
@@ -393,6 +376,19 @@ void FlowGraphChecker::VisitRedefinition(RedefinitionInstr* def) {
393376
ASSERT(def->value()->definition() != def);
394377
}
395378

379+
void FlowGraphChecker::VisitInstanceCall(InstanceCallInstr* instr) {
380+
// Force-optimized functions may not have instance calls inside them because
381+
// we do not reset ICData for these.
382+
ASSERT(!flow_graph_->function().ForceOptimize());
383+
}
384+
385+
void FlowGraphChecker::VisitPolymorphicInstanceCall(
386+
PolymorphicInstanceCallInstr* instr) {
387+
// Force-optimized functions may not have instance calls inside them because
388+
// we do not reset ICData for these.
389+
ASSERT(!flow_graph_->function().ForceOptimize());
390+
}
391+
396392
// Main entry point of graph checker.
397393
void FlowGraphChecker::Check(const char* pass_name) {
398394
if (FLAG_trace_compiler) {

0 commit comments

Comments
 (0)