Skip to content

Commit

Permalink
Postpone addition of 'typeArguments' getter on Invocation class until…
Browse files Browse the repository at this point in the history
… the

Dart 2.0 revision of the core library, since it breaks google3 Dart integration.

Change-Id: If9036f6e8d90b30f142a245ae16754c177f8461e
Reviewed-on: https://dart-review.googlesource.com/10702
Commit-Queue: Régis Crelier <regis@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
  • Loading branch information
crelier authored and commit-bot@chromium.org committed Oct 3, 2017
1 parent d96b293 commit 23b57df
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,6 @@ abstract class int extends self::num {
}
abstract class Invocation extends self::Object {
abstract get memberName() → self::Symbol;
abstract get typeArguments() → self::List<self::Type>;
abstract get positionalArguments() → self::List<dynamic>;
abstract get namedArguments() → self::Map<self::Symbol, dynamic>;
abstract get isMethod() → self::bool;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,6 @@ library dart:core:
- toRadixString
- class Invocation
- memberName
- typeArguments
- positionalArguments
- namedArguments
- isMethod
Expand Down
7 changes: 0 additions & 7 deletions sdk/lib/core/invocation.dart
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,6 @@ abstract class Invocation {
/** The name of the invoked member. */
Symbol get memberName;

/**
* An unmodifiable view of the type arguments of the call.
*
* If the call is not generic, the type arguments list is empty.
*/
List<Type> get typeArguments;

/**
* An unmodifiable view of the positional arguments of the call.
*
Expand Down

2 comments on commit 23b57df

@jrote1
Copy link

@jrote1 jrote1 commented on 23b57df Oct 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crelier Did this make it into dev3.0 as I am getting this error in DDC Missing concrete implementation of getter 'Invocation.typeArguments'. (package:mockito/src/invocation_matcher.dart, line 65, col 7)

@crelier
Copy link
Contributor Author

@crelier crelier commented on 23b57df Oct 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know, 2.0.0-dev.3.0 was cut yesterday, and this was committed 2 days ago, so it should. But the error you see would indicate it did not make it. Sorry, I do not know for sure (and on vacation today).

Please sign in to comment.