-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Postpone addition of 'typeArguments' getter on Invocation class until…
… the Dart 2.0 revision of the core library, since it breaks google3 Dart integration. Change-Id: If9036f6e8d90b30f142a245ae16754c177f8461e Reviewed-on: https://dart-review.googlesource.com/10702 Commit-Queue: Régis Crelier <regis@google.com> Reviewed-by: Keerti Parthasarathy <keertip@google.com>
- Loading branch information
Showing
3 changed files
with
0 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23b57df
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@crelier Did this make it into dev3.0 as I am getting this error in DDC
Missing concrete implementation of getter 'Invocation.typeArguments'. (package:mockito/src/invocation_matcher.dart, line 65, col 7)
23b57df
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I know, 2.0.0-dev.3.0 was cut yesterday, and this was committed 2 days ago, so it should. But the error you see would indicate it did not make it. Sorry, I do not know for sure (and on vacation today).